<html>
<head><meta charset="utf-8"><title>reason for r+ sha · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/reason.20for.20r.2B.20sha.html">reason for r+ sha</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="213956500"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/reason%20for%20r%2B%20sha/near/213956500" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/reason.20for.20r.2B.20sha.html#213956500">(Oct 20 2020 at 17:56)</a>:</h4>
<p>Is there any reason a reviewer would want to use <code>@bors r+ &lt;sha&gt;</code>? IIUC, bors will not merge if new commits are pushed.</p>



<a name="213956862"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/reason%20for%20r%2B%20sha/near/213956862" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/reason.20for.20r.2B.20sha.html#213956862">(Oct 20 2020 at 17:58)</a>:</h4>
<p>For r+ it may not be very useful except for preventing a race condition between review/r+ and the PR author. I guess for try it could be useful to perform a comparison between multiple commits in a PR.</p>



<a name="213957312"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/reason%20for%20r%2B%20sha/near/213957312" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/reason.20for.20r.2B.20sha.html#213957312">(Oct 20 2020 at 18:01)</a>:</h4>
<p><span class="user-mention" data-user-id="307537">@Camelid</span> that's actually used by bors itself all the time</p>



<a name="213957396"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/reason%20for%20r%2B%20sha/near/213957396" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/reason.20for.20r.2B.20sha.html#213957396">(Oct 20 2020 at 18:02)</a>:</h4>
<p>like, this is the markdown bors writes in the "commit has been approved by person" message</p>



<a name="213957404"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/reason%20for%20r%2B%20sha/near/213957404" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/reason.20for.20r.2B.20sha.html#213957404">(Oct 20 2020 at 18:02)</a>:</h4>
<div class="codehilite"><pre><span></span><code>:pushpin: Commit c2af254e3bc20792da5ddc21eaf2306b2c379f1a has been approved by `wesleywiser`

&lt;!-- @bors r=wesleywiser c2af254e3bc20792da5ddc21eaf2306b2c379f1a --&gt;
&lt;!-- homu: {&quot;type&quot;:&quot;Approved&quot;,&quot;sha&quot;:&quot;c2af254e3bc20792da5ddc21eaf2306b2c379f1a&quot;,&quot;approver&quot;:&quot;wesleywiser&quot;} --&gt;
</code></pre></div>



<a name="213957446"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/reason%20for%20r%2B%20sha/near/213957446" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/reason.20for.20r.2B.20sha.html#213957446">(Oct 20 2020 at 18:02)</a>:</h4>
<p>the first message is for us humans</p>



<a name="213957475"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/reason%20for%20r%2B%20sha/near/213957475" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/reason.20for.20r.2B.20sha.html#213957475">(Oct 20 2020 at 18:02)</a>:</h4>
<p>the last message is for other bots like crater and rustc-perf that follow what bors is doing</p>



<a name="213957525"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/reason%20for%20r%2B%20sha/near/213957525" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/reason.20for.20r.2B.20sha.html#213957525">(Oct 20 2020 at 18:03)</a>:</h4>
<p>but the one in the middle is useful when bors "synchronizes" its state with the PR on github</p>



<a name="213957608"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/reason%20for%20r%2B%20sha/near/213957608" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/reason.20for.20r.2B.20sha.html#213957608">(Oct 20 2020 at 18:03)</a>:</h4>
<p>if it didn't specify the hash (in the message after the reviewer's r+), an r+ at the beginning of a long conversation would approve the last commit pushed by the author</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>